rgw: Remove unused Parameter in Function RGWConf::init() #17129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wen Zhang <zhangwen1@unionpay.com>
amitkumar50
approved these changes
Aug 27, 2017
|
Jenkins Retest please |
|
@xiexingguo Could you review it? Tks~ |
|
I am forwarding this to @joscollin |
|
Jenkins retest this please |
|
Jenkins retest this please |
joscollin
requested changes
Sep 1, 2017
| @@ -385,7 +385,7 @@ class RGWEnv; | |||
| class RGWConf { | |||
| friend class RGWEnv; | |||
| protected: | |||
There was a problem hiding this comment.
Drop protected as it is not being used and RGWEnv is a friend of RGWConf.
There was a problem hiding this comment.
protected has been dropped in patch #17432
There was a problem hiding this comment.
@C2python Yes. As your response got delayed, I have submitted that in my patch. I will continue the review of this. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wen Zhang zhangwen1@unionpay.com