doc: rgw: mention the civetweb support for binding to multiple ports #17141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins render docs |
|
Doc render available at http://docs.ceph.com/ceph-prs/17141/ |
|
@mattbenjamin @mdw-at-linuxbox does this look okay? |
cbodley
reviewed
Aug 23, 2017
doc/install/install-ceph-gateway.rst
Outdated
| .. versionadded :: Luminous | ||
|
|
||
| Furthermore, civetweb can be made to bind to multiple ports, multiple ports | ||
| needs to be separated by ``+`` in the configuration. This allows for use cases where |
There was a problem hiding this comment.
needs -> need. though it may read better as can be made to bind to multiple ports by separating them with ``+`` in the configuration.
There was a problem hiding this comment.
Maybe I should also throw in that this has the advantage that the threadpool for civetweb gets shared in this case?
We support binding multiple ports in civetweb after the upgrade to 1.8, clarify this in the documentation as well Fixes: http://tracker.ceph.com/issues/20942 Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
theanalyst
force-pushed
the
doc-civetweb-ports
branch
from
2c4a4e0
to
01740c6
Compare
|
@cbodley updated |
cbodley
approved these changes
Aug 30, 2017
|
@cbodley ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support binding multiple ports in civetweb after the upgrade to 1.8,
clarify this in the documentation as well
Fixes: http://tracker.ceph.com/issues/20942
Signed-off-by: Abhishek Lekshmanan abhishek@suse.com