Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore/NVMEDevice: change write_bl to bl #17145

Merged
merged 1 commit into from Aug 31, 2017

Conversation

Projects
None yet
3 participants
@optimistyzy
Copy link
Contributor

commented Aug 22, 2017

With this patch, both read and write can use this field in
task.

Signed-off-by: Ziye Yang optimistyzy@gmail.com
Signed-off-by: Pan Liu wanjun.lp@alibaba-inc.com

@optimistyzy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 22, 2017

@optimistyzy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2017

Jenkins, retest this please

@optimistyzy optimistyzy force-pushed the optimistyzy:822_bl branch from e066579 to 28e02cf Aug 23, 2017

@optimistyzy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2017

@yuyuyu101 @liupan1111 This is a cleanup.

@@ -323,6 +323,11 @@ struct Task {
io_request.nseg = 0;
}

void copy_to_buf(bufferptr p, uint64_t off, uint64_t len) {

This comment has been minimized.

Copy link
@yuyuyu101

yuyuyu101 Aug 23, 2017

Member

bufferptr &&p

This comment has been minimized.

Copy link
@optimistyzy

optimistyzy Aug 23, 2017

Author Contributor

why &&p, I think that bufferptr p is sufficient

This comment has been minimized.

Copy link
@yuyuyu101

yuyuyu101 Aug 23, 2017

Member

I don't think so... @tchaikov plz correct me if wrong

@@ -1090,11 +1095,10 @@ int NVMEDevice::aio_read(
Task *t = new Task(this, IOCommand::READ_COMMAND, off, len);

bufferptr p = buffer::create_page_aligned(len);
pbl->append(p);
pbl->append(t->bl);

This comment has been minimized.

Copy link
@yuyuyu101

yuyuyu101 Aug 23, 2017

Member

std::move(

This comment has been minimized.

Copy link
@optimistyzy

optimistyzy Aug 23, 2017

Author Contributor

Could you explain why use std:move() sice at this time, there is no data copy yet. Also in kernelDevice.cc, it also directly use append.

char *buf = p.c_str();
t->fill_cb = [buf, t]() {
t->copy_to_buf(buf, 0, t->len);
pbl->append(t->bl);

This comment has been minimized.

Copy link
@yuyuyu101

yuyuyu101 Aug 23, 2017

Member

std::move(

@optimistyzy optimistyzy force-pushed the optimistyzy:822_bl branch from 28e02cf to 22c12b5 Aug 23, 2017

@liewegas liewegas changed the title NVMEDevice: change write_bl to bl os/bluestore/NVMEDevice: change write_bl to bl Aug 25, 2017

@liewegas liewegas added the bluestore label Aug 29, 2017

NVMEDevice: change write_bl to bl
With this patch, both read and write can use this field in
task.

Signed-off-by: Ziye Yang <optimistyzy@gmail.com>
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>

@optimistyzy optimistyzy force-pushed the optimistyzy:822_bl branch from 22c12b5 to fee7666 Aug 31, 2017

@optimistyzy

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2017

@yuyuyu101 @liupan1111 Could you review this patch again?

@yuyuyu101 yuyuyu101 merged commit 5923e77 into ceph:master Aug 31, 2017

4 of 5 checks passed

make check make check failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.