os/bluestore/NVMEDevice: change write_bl to bl #17145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins, retest this please |
|
@yuyuyu101 @liupan1111 This is a cleanup. |
yuyuyu101
reviewed
Aug 23, 2017
src/os/bluestore/NVMEDevice.cc
Outdated
| @@ -323,6 +323,11 @@ struct Task { | |||
| io_request.nseg = 0; | |||
| } | |||
|
|
|||
| void copy_to_buf(bufferptr p, uint64_t off, uint64_t len) { | |||
There was a problem hiding this comment.
why &&p, I think that bufferptr p is sufficient
There was a problem hiding this comment.
I don't think so... @tchaikov plz correct me if wrong
yuyuyu101
reviewed
Aug 23, 2017
src/os/bluestore/NVMEDevice.cc
Outdated
| @@ -1090,11 +1095,10 @@ int NVMEDevice::aio_read( | |||
| Task *t = new Task(this, IOCommand::READ_COMMAND, off, len); | |||
|
|
|||
| bufferptr p = buffer::create_page_aligned(len); | |||
| pbl->append(p); | |||
| pbl->append(t->bl); | |||
There was a problem hiding this comment.
Could you explain why use std:move() sice at this time, there is no data copy yet. Also in kernelDevice.cc, it also directly use append.
yuyuyu101
reviewed
Aug 23, 2017
src/os/bluestore/NVMEDevice.cc
Outdated
| char *buf = p.c_str(); | ||
| t->fill_cb = [buf, t]() { | ||
| t->copy_to_buf(buf, 0, t->len); | ||
| pbl->append(t->bl); |
liewegas
changed the title
With this patch, both read and write can use this field in task. Signed-off-by: Ziye Yang <optimistyzy@gmail.com> Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>
|
@yuyuyu101 @liupan1111 Could you review this patch again? |
yuyuyu101
approved these changes
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch, both read and write can use this field in
task.
Signed-off-by: Ziye Yang optimistyzy@gmail.com
Signed-off-by: Pan Liu wanjun.lp@alibaba-inc.com