Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd:rm unnecessary conversion from string to char* in image-meta function #17184

Merged
merged 1 commit into from Aug 23, 2017

Conversation

Projects
None yet
3 participants
@PCzhangPC
Copy link

commented Aug 23, 2017

the APIs in librbd receive string type as parameter, so there is no need to convert string to char* in image-meta function

Signed-off-by: PCzhangPC pengcheng.zhang@easystack.cn

PCzhangPC
rbd:rm unnecessary conversion from string to char* in image-meta func…
…tion

the APIs in librbd receive string type as parameter, so there is no need to convert string to char* in image-meta function

Signed-off-by: PCzhangPC <pengcheng.zhang@easystack.cn>

@PCzhangPC PCzhangPC force-pushed the PCzhangPC:rmconv branch from c9a35fc to 192f937 Aug 23, 2017

@PCzhangPC

This comment has been minimized.

Copy link
Author

commented Aug 23, 2017

@yangdongsheng @joscollin @dillaman please help to review this

@dillaman
Copy link
Contributor

left a comment

lgtm

@dillaman dillaman merged commit c851ad0 into ceph:master Aug 23, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.