mon/OSDMonitor: check creating_pgs.last_scan_epoch instead when sendi… #17248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng creates we cannot be sure that the creating_pgs_by_osd_epoch is in sync with creating_pgs.pgs even if mapping.get_epoch() is less or equal to creating_pgs_epoch. because, 1) the access to mapping.epoch is not protected by lock, 2) even worse, the mapping might be not finished yet when we are trying to send pg-creates to subscribers. so instead of comparing creating_pgs_epoch with mapping's epoch, we should compare it with creating_pgs.last_scan_epoch. the former is updated once the creating_pgs_by_osd_epoch is updated with the latest mapping's epoch and creating_pgs.pgs; the latter is updated with current osdmap's epoch when creating_pgs is being updated with the inc osd map. if we are using a creating_pgs_epoch in sync, creating_pgs_epoch should be creating_pgs.last_scan_epoch + 1. Fixes: http://tracker.ceph.com/issues/20785 Signed-off-by: Kefu Chai <kchai@redhat.com>
|
make check succeeded |
liewegas
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng creates
we cannot be sure that the creating_pgs_by_osd_epoch is in sync with
creating_pgs.pgs even if mapping.get_epoch() is less or equal to
creating_pgs_epoch. because, 1) the access to mapping.epoch is not
protected by lock, 2) even worse, the mapping might be not finished yet
when we are trying to send pg-creates to subscribers.
so instead of comparing creating_pgs_epoch with mapping's epoch, we
should compare it with creating_pgs.last_scan_epoch. the former is
updated once the creating_pgs_by_osd_epoch is updated with the latest
mapping's epoch and creating_pgs.pgs; the latter is updated with current
osdmap's epoch when creating_pgs is being updated with the inc osd map.
if we are using a creating_pgs_epoch in sync, creating_pgs_epoch should
be creating_pgs.last_scan_epoch + 1.
Fixes: http://tracker.ceph.com/issues/20785
Signed-off-by: Kefu Chai kchai@redhat.com