Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librbd: should not set self as remote peer #17300

Merged
merged 1 commit into from Sep 7, 2017
Merged

librbd: should not set self as remote peer #17300

merged 1 commit into from Sep 7, 2017

Conversation

Songweibin
Copy link
Contributor

Signed-off-by: songweibin song.weibin@zte.com.cn

@Songweibin
librbd: cannot set self as remote peer
1dd597b 
Signed-off-by: songweibin <song.weibin@zte.com.cn>
dillaman
dillaman approved these changes Aug 28, 2017
View reviewed changes
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- although it doesn't provide full protection since I could run the rbd CLI from a node where I copied "/etc/ceph/.conf" to "/etc/ceph/.conf" and get passed this check.

@dillaman dillaman merged commit 5995bca into ceph:master Sep 7, 2017
@Songweibin Songweibin deleted the wip-mirror-peer-set branch September 7, 2017 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillaman dillaman dillaman approved these changes

Assignees
No one assigned
Labels
cleanup needs-qa rbd
Projects
None yet
Milestone
No milestone
2 participants
@Songweibin @dillaman