Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa: create_cache_pool no longer runs 'pool application enable' #17312

Merged
merged 1 commit into from Aug 29, 2017
Merged

qa: create_cache_pool no longer runs 'pool application enable' #17312

merged 1 commit into from Aug 29, 2017

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Aug 28, 2017

@cbodley
Copy link
Contributor Author

cbodley commented Aug 28, 2017

tested in http://pulpito.ceph.com/cbodley-2017-08-28_10:17:30-rgw-master-distro-basic-mira/ and cache pool creation was successful:

2017-08-28T15:17:08.959 INFO:tasks.rgw:Creating data pools
2017-08-28T15:17:08.961 DEBUG:tasks.rgw:Obtaining remote for client client.0
2017-08-28T15:17:08.964 INFO:teuthology.orchestra.run.mira042:Running: 'sudo ceph osd erasure-code-profile set client.0 crush-failure-domain=osd k=2 m=1 --cluster ceph'
2017-08-28T15:17:09.395 INFO:teuthology.orchestra.run.mira042:Running: 'sudo ceph osd pool create .rgw.buckets 64 64 erasure client.0 --cluster ceph'
2017-08-28T15:17:11.418 INFO:teuthology.orchestra.run.mira042.stderr:pool '.rgw.buckets' created
2017-08-28T15:17:11.435 INFO:teuthology.orchestra.run.mira042:Running: 'sudo ceph osd pool application enable .rgw.buckets rgw --cluster ceph'
2017-08-28T15:17:12.470 INFO:teuthology.orchestra.run.mira042.stderr:enabled application 'rgw' on pool '.rgw.buckets'
2017-08-28T15:17:12.580 INFO:teuthology.orchestra.run.mira042:Running: 'sudo ceph osd pool create .rgw.buckets.cache 64 --cluster ceph'
2017-08-28T15:17:13.448 INFO:teuthology.orchestra.run.mira042.stderr:pool '.rgw.buckets.cache' created
2017-08-28T15:17:13.469 INFO:teuthology.orchestra.run.mira042:Running: 'sudo ceph osd tier add-cache .rgw.buckets .rgw.buckets.cache 67108864 --cluster ceph'
2017-08-28T15:17:14.439 INFO:teuthology.orchestra.run.mira042.stderr:pool '.rgw.buckets.cache' is now (or already was) a cache tier of '.rgw.buckets'
2017-08-28T15:17:14.464 INFO:teuthology.orchestra.run.mira042:Running: 'sudo ceph osd pool application enable .rgw.buckets rgw --cluster ceph'
2017-08-28T15:17:15.435 INFO:teuthology.orchestra.run.mira042.stderr:enabled application 'rgw' on pool '.rgw.buckets'
2017-08-28T15:17:15.454 DEBUG:tasks.rgw:Pools created

tchaikov
tchaikov reviewed Aug 28, 2017
View reviewed changes
qa/tasks/util/rados.py Outdated
@@ -55,7 +55,7 @@ def create_cache_pool(remote, base_name, cache_name, pgnum, size, cluster_name="
])
if application:
remote.run(args=[
'sudo', 'ceph', 'osd', 'pool', 'application', 'enable', name, application, '--cluster', cluster_name
'sudo', 'ceph', 'osd', 'pool', 'application', 'enable', base_name, application, '--cluster', cluster_name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should be cache_name, otherwise we are tagging the base pool repeatedly, for example, in rgw.py's create_pools(),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchaikov thank you, fixed

@tchaikov
Copy link
Contributor

rerunning at http://pulpito.ceph.com/kchai-2017-08-29_02:33:42-rgw-master-distro-basic-smithi/

@cbodley
Copy link
Contributor Author

cbodley commented Aug 29, 2017

test failures again at http://pulpito.ceph.com/cbodley-2017-08-28_11:41:39-rgw-master-distro-basic-mira/

Error EINVAL: application must be enabled on base tier

it looks like you can't run this on a cache tier, so i've removed the command from create_cache_pools() altogether. scheduled another run to verify

@cbodley cbodley changed the title qa: fix pool name in create_cache_pool qa: create_cache_pool no longer runs 'pool application enable' Aug 29, 2017
tchaikov
tchaikov approved these changes Aug 29, 2017
View reviewed changes
Copy link
Contributor

@tchaikov tchaikov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, seems "osd pool application *" can only be applied to base pool.

@cbodley
Copy link
Contributor Author

cbodley commented Aug 29, 2017

okay, got a clean run at http://pulpito.ceph.com/cbodley-2017-08-29_11:36:22-rgw-master-distro-basic-mira/

@tchaikov tchaikov merged commit d24ba40 into ceph:master Aug 29, 2017
@cbodley cbodley deleted the wip-21155 branch August 29, 2017 16:33
@cbodley
Copy link
Contributor Author

cbodley commented Aug 29, 2017

@tchaikov thanks, as always, for the help and review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

Assignees
No one assigned
Labels
bug-fix tests
Projects
None yet
Milestone
No milestone
2 participants
@cbodley @tchaikov