mon/OSDMonitor: make 'osd crush class rename' idempotent #17330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
liewegas
reviewed
Aug 29, 2017
| goto reply; | ||
| } | ||
|
|
||
| if (newcrush.class_exists(dstname)) { |
There was a problem hiding this comment.
should we keep this, so that if both src and dest exist, you still get EEXIST?
There was a problem hiding this comment.
CrushWrapper::rename_class will do this:
int CrushWrapper::rename_class(const string& srcname, const string& dstname)
{
auto i = class_rname.find(srcname);
if (i == class_rname.end())
return -ENOENT;
auto j = class_rname.find(dstname);
if (j != class_rname.end())
return -EEXIST;
liewegas
approved these changes
Aug 29, 2017
liewegas
added a commit
that referenced
this pull request
Aug 29, 2017
mon/OSDMonitor: make 'osd crush class rename' idempotent Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn