qa/suites/krbd: rbd_xfstests job overhaul #17346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./check expects FSTYP, so use that throughout. Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
AFAICT ./check doesn't query EXT4_MKFS_OPTIONS or BTRFS_MKFS_OPTIONS, We don't need anything special for xfs, so remove all of them to avoid confusion. Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
xfstests is a pain to build on trusty, xenial and centos7 with a single script. It is also very sensitive to dependencies, which again need to be managed on all those distros -- different sets of supported commands and switches, some versions have known bugs, etc. Download a pre-built, statically linked tarball and use it instead. The tarball was generated using xfstests-bld by Ted Ts'o, with a number of tweaks by myself (mostly concerning the build environment). Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Different filesystems (and further, different configurations of the same filesystem) need different exclude lists. Hard coding the list in a wrapper script is inflexible. Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
ext4 seems to be a better choice for our purposes -- less test churn, rather small and reliable exclude list. All excluded tests but generic/050 fail with no krbd in the mix, most have popped up on linux-ext4 list at least once. Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
|
I think we should port this to luminous, I tried to cherry-pick for a PR but strangely it doesn't apply cleanly without conflict. |
|
@vasukulkarni That's the plan. I wanted to delay it until all the one-offs were sorted out though. |
|
luminous backport: #17970 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been test running this for about a week. There is a small list of one-off failures that I'll keep an eye for, but I think it's reliable enough now.