New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add example of setting pool in cephfs layout #17372
Conversation
doc/cephfs/file-layouts.rst
Outdated
.. code-block:: bash | ||
|
||
$ mkdir /mnt/cephfs/myecdir | ||
$ setfattr -n ceph.dir.layout.pool -v cephfs_data_ssd /mnt/cephfs/myecdir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this doc change -- but do we need a process to auto-tag the data pool as being owned by CephFS when this attribute is set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, somebody called "Jason" already updated add_data_pool's implementation to add the tag. Smart guy!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank goodness -- just wanted to ensure there was no magic backdoor of config settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should reconcile the original doc using cephfs_data_ssd
pool name with your intent here to document EC pools via the myecdir
folder name.
Pick one, or duplicate for both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point, head was in two places. Updated.
b446183
to
b77db8c
Compare
doc/cephfs/file-layouts.rst
Outdated
|
||
All new files created within that directory will now inherit its layout and place their data in your newly added pool. | ||
|
||
You may notice that object counts in your primary data pool (the one passed to `fs new`) continue to increase, even if files are being created in the pool you added. This is normal: the file data is stored in the pool specified by the layout, but a small amount of metadata is kept in the primary data pool for all files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if "fs new" is meant to be displayed in a mono-spaced font then double backticks are needed (vs. single ones)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: John Spray <john.spray@redhat.com>
b77db8c
to
dee090e
Compare
Signed-off-by: John Spray john.spray@redhat.com