Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: disable VTA on options.cc #17393

Merged
merged 1 commit into from Sep 5, 2017

Conversation

tchaikov
Copy link
Contributor

to silence following warning and to avoid compiling this file twice:

ceph/src/common/options.cc: In function ‘std::vector get_global_options()’:
ceph/src/common/options.cc:151:21: note: variable tracking
size limit exceeded with -fvar-tracking-assignments, retrying without
std::vector get_global_options() {
^~~~~~~~~~~~~~~~~~

Signed-off-by: Kefu Chai kchai@redhat.com

to silence following warning and to avoid compiling this file twice:

ceph/src/common/options.cc: In function ‘std::vector<Option> get_global_options()’:
ceph/src/common/options.cc:151:21: note: variable tracking
size limit exceeded with -fvar-tracking-assignments, retrying without
 std::vector<Option> get_global_options() {
                     ^~~~~~~~~~~~~~~~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

tchaikov commented Sep 5, 2017

@tchaikov tchaikov merged commit a005251 into ceph:master Sep 5, 2017
@tchaikov tchaikov deleted the wip-cmake-disable-vta branch September 5, 2017 01:33
@wjwithagen
Copy link
Contributor

@tchikow
Sorry for being late to this party, but this flag is not available/needed in clang.
And options.cc compiles just fine.
Now I do not expect Clang to grow this option so perhaps make this conditional on GCC.
Or generate a remark that VTA is not needed with Clang.
When running cmake on ceph I saw the HAS_VTA notices and started to investigate what was going on, and if it was an error.

@tchaikov
Copy link
Contributor Author

tchaikov commented Sep 5, 2017

@wjwithagen we disable VTA at multiple places, if you don't like it please send a PR.

@wjwithagen
Copy link
Contributor

@tchaikov
Disableing is fine, Clang does not care.
It was the HAS_VTA is off remark in the parsing of the CMAkeFiles that got my attention.
But I shubmit a PR for Cmake with Clang to not report VTA messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants