os/bluestore: don't re-initialize csum-setting for existing blobs #17398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
liewegas
approved these changes
Aug 31, 2017
liewegas
added
needs-backport
needs-qa
wip-sage2-testing
and removed
needs-backport
labels
xiexingguo
force-pushed
the
wip-21175
branch
from
485af44
to
22740cc
Compare
|
changeset:
diff --git a/src/os/bluestore/BlueStore.cc b/src/os/bluestore/BlueStore.cc
index f62ef4c..f3cbca7 100644
--- a/src/os/bluestore/BlueStore.cc
+++ b/src/os/bluestore/BlueStore.cc
@@ -9931,10 +9931,10 @@ int BlueStore::_do_alloc_write(
}
if (csum != Checksummer::CSUM_NONE) {
dout(20) << __func__ << " initialize csum setting for new blob " << *b
- << " csum_type " << Checksummer::get_csum_type_string(csum)
- << " csum_order " << csum_order
- << " csum_length 0x" << std::hex << csum_length << std::dec
- << dendl;
+ << " csum_type " << Checksummer::get_csum_type_string(csum)
+ << " csum_order " << csum_order
+ << " csum_length 0x" << std::hex << csum_length << std::dec
+ << dendl;
dblob.init_csum(csum, csum_order, csum_length);
}
} |
The global checksum setting may change, e.g., from NONE to CRC32, which can cause improper re-initialization of the csum-settings of existing blobs(e.g., partial write/overwrite may turn out to shrink 'csum_data'). We could develop some complicated solutions but for now let's not bother since the above scenario is rare. Fixes: http://tracker.ceph.com/issues/21175 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
So we don't output anything if csum is currently off: _do_alloc_write blob Blob(0x7fad7cc25950 blob([0x42a80000~10000] none/0x1) Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global checksum setting may change, e.g., from NONE to CRC32,
which can cause improper re-initialization of the csum-settings of
existing blobs(e.g., partial write/overwrite may turn out to shrink
'csum_data').
We could develop some complicated solutions but for now let's not
bother since the above scenario is rare.
Fixes: http://tracker.ceph.com/issues/21175
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn