New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgw: rgw_rados: set_attrs now sets the same time for BI & object #17400
Conversation
`RGWRados::set_attrs()` used to set slightly different mtimes for the object and in the bucket dir entry as we do an object write and set the time at bucket index as the time at that point. Fix this by using the setting the same mtime for the object as well. Fixes: http://tracker.ceph.com/issues/21200 Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
currently used #17395 for testing this (eg,. as reported in http://tracker.ceph.com/issues/21200) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Recently, I have encountered a problem: |
rgw: When using versioning, "call Rados::set_attrs for a version (for example, set self-defined metadata)" resulting in inconsistency between [BI_BUCKET_OBJS_INDEX: entry.meta.mtime] and [BI_BUCKET_OBJ_INSTANCE_INDEX: entry.meta.mtime], [DATA : mtime].(The current version cannot be correctly deleted in the lifecycle function) related questions: ceph#17400
rgw: When using versioning, "call Rados::set_attrs for a version (for example, set self-defined metadata)" resulting in inconsistency between [BI_BUCKET_OBJS_INDEX: entry.meta.mtime] and [BI_BUCKET_OBJ_INSTANCE_INDEX: entry.meta.mtime], [DATA : mtime].(The current version cannot be correctly deleted in the lifecycle function) related questions: ceph#17400 Fixes: http://tracker.ceph.com/issues/39368 Signed-off-by: Snow Si <2804536059@qq.com>
rgw: When using versioning, "call Rados::set_attrs for a version (for example, set self-defined metadata)" resulting in inconsistency between [BI_BUCKET_OBJS_INDEX: entry.meta.mtime] and [BI_BUCKET_OBJ_INSTANCE_INDEX: entry.meta.mtime], [DATA : mtime].(The current version cannot be correctly deleted in the lifecycle function) related questions: ceph#17400 Fixes: http://tracker.ceph.com/issues/39368 Signed-off-by: Snow Si <silonghu@inspur.com>
rgw: When using versioning, "call Rados::set_attrs for a version (for example, set self-defined metadata)" resulting in inconsistency between [BI_BUCKET_OBJS_INDEX: entry.meta.mtime] and [BI_BUCKET_OBJ_INSTANCE_INDEX: entry.meta.mtime], [DATA : mtime].(The current version cannot be correctly deleted in the lifecycle function) related questions: ceph#17400 Fixes: http://tracker.ceph.com/issues/39368 Signed-off-by: Snow Si <silonghu@inspur.com>
rgw: When using versioning, "call Rados::set_attrs for a version (for example, set self-defined metadata)" resulting in inconsistency between [BI_BUCKET_OBJS_INDEX: entry.meta.mtime] and [BI_BUCKET_OBJ_INSTANCE_INDEX: entry.meta.mtime], [DATA : mtime].(The current version cannot be correctly deleted in the lifecycle function) related questions: ceph#17400 Fixes: http://tracker.ceph.com/issues/39368 Signed-off-by: Snow Si <silonghu@inspur.com>
related questions: ceph#17400 Fixes: http://tracker.ceph.com/issues/39368 Signed-off-by: Snow Si <silonghu@inspur.com>
related questions: ceph#17400 Fixes: http://tracker.ceph.com/issues/39368 Signed-off-by: Snow Si <silonghu@inspur.com>
related questions: ceph#17400 Fixes: http://tracker.ceph.com/issues/39368 Signed-off-by: Snow Si <silonghu@inspur.com>
related questions: ceph#17400 Fixes: http://tracker.ceph.com/issues/39368 Signed-off-by: Snow Si <silonghu@inspur.com>
related questions: ceph#17400 Fixes: http://tracker.ceph.com/issues/39368 Signed-off-by: Snow Si <silonghu@inspur.com>
RGWRados::set_attrs()
used to set slightly different mtimes for theobject and in the bucket dir entry as we do an object write and set the
time at bucket index as the time at that point. Fix this by using the
setting the same mtime for the object as well.
Fixes: http://tracker.ceph.com/issues/21200
Signed-off-by: Abhishek Lekshmanan abhishek@suse.com