boost: remove boost submodule #17405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-remove-boost-submodule
branch
from
c46ef99
to
9faba52
Compare
tchaikov
force-pushed
the
wip-remove-boost-submodule
branch
2 times, most recently
from
8d73f75
to
656cbeb
Compare
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-remove-boost-submodule
branch
from
656cbeb
to
f04436b
Compare
|
tested "make-dist" locally by running it and inspecting it using |
liewegas
reviewed
Sep 1, 2017
| boost_fname=boost_${boost_version_underscore}.tar.bz2 | ||
| echo "downloading boost_$boost_version..." | ||
| wget --no-verbose -O $boost_fname \ | ||
| https://downloads.sourceforge.net/project/boost/boost/$boost_version/$boost_fname |
There was a problem hiding this comment.
Should we stash a copy of this on download.ceph.com or something?
There was a problem hiding this comment.
@alfredodeza do we use a cache enabled http proxy in our CI infrastructure?
There was a problem hiding this comment.
we don't have any kind of caching in our CI
alfredodeza
approved these changes
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.