mon/MDSMonitor: fix a bug at preprocess_beacon #17415
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangshuguangbj
force-pushed
the
bug_mon_mdsmonitor_assert
branch
from
b2239ce
to
b1b541f
Compare
liewegas
reviewed
Sep 1, 2017
src/mon/MDSMonitor.cc
Outdated
| @@ -321,7 +321,8 @@ bool MDSMonitor::preprocess_beacon(MonOpRequestRef op) | |||
|
|
|||
| // check privileges, ignore if fails | |||
| MonSession *session = m->get_session(); | |||
| assert(session); | |||
| if(!session) | |||
There was a problem hiding this comment.
ok, i will modify this, thank you.
liewegas
changed the title
when a mds node reboot, mon deal beacon message from this mds. The connection between mon and MDS has been released.This will cause Session is empty.Then this mon will assert(session); BTW in mon/OSDMonitor.cc,this bug is fixed. Signed-off-by: wangshuguang <wangshugaung@inspur.com>
wangshuguangbj
force-pushed
the
bug_mon_mdsmonitor_assert
branch
from
b1b541f
to
189d9cb
Compare
|
@liewegas I modified this yesterday,please review this for me.Thank you. |
liewegas
approved these changes
Sep 5, 2017
batrick
approved these changes
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a mds node reboot, mon deal beacon message from this mds.
The connection between mon and MDS has been released.This will cause Session is empty.Then this mon will assert(session);
BTW in mon/OSDMonitor.cc,this bug is fixed.
Signed-off-by: wangshuguang wangshugaung@inspur.com