CMake: in case of bad "ALLOCATOR" selected issue warning #17422
Conversation
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
src/CMakeLists.txt
Outdated
| @@ -295,6 +295,9 @@ elseif(ALLOCATOR STREQUAL "jemalloc") | |||
| set(TCMALLOC_srcs perfglue/disabled_heap_profiler.cc) | |||
| elseif(ALLOCATOR STREQUAL "libc") | |||
| set(TCMALLOC_srcs perfglue/disabled_heap_profiler.cc) | |||
| else() | |||
| set(TCMALLOC_srcs perfglue/disabled_heap_profiler.cc) | |||
| message(WARNING "Possibly incorrect allocator selected:" ${ALLOCATOR}) | |||
There was a problem hiding this comment.
Can we raise an error here?
There was a problem hiding this comment.
yes, we should error out here with an error message.
There was a problem hiding this comment.
Please don't.
FreeBSD has jemalloc as default allocator.
Defining it however, will show that the additional tools are not available in ways that are expected.
So for example rocksdb starts doing wrong things.
If you want to error out, then please make an exemption for FreeBSD.
There was a problem hiding this comment.
it's always set in $top_srcdir/CMakeLists.txt.
There was a problem hiding this comment.
You are right. So FreeBSD ends in libc.
Why not error out earlier, like in $top_srcdir/CMakeLists.txt?
|
@aclamk ping? |
src/CMakeLists.txt
Outdated
| @@ -295,6 +295,9 @@ elseif(ALLOCATOR STREQUAL "jemalloc") | |||
| set(TCMALLOC_srcs perfglue/disabled_heap_profiler.cc) | |||
| elseif(ALLOCATOR STREQUAL "libc") | |||
| set(TCMALLOC_srcs perfglue/disabled_heap_profiler.cc) | |||
| else() | |||
| set(TCMALLOC_srcs perfglue/disabled_heap_profiler.cc) | |||
| message(FATAL_ERROR "Possibly incorrect allocator selected:" ${ALLOCATOR}) | |||
There was a problem hiding this comment.
nit, add a space after :. BTW, could put the variable right into the string to print, also could use a stronger tone here. like
message(FATAL_ERROR "Unsupported allocator selected: ${ALLOCATOR}")Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
aclamk
force-pushed
the
fix-cmake-unsupported-allocator
branch
from
d4b31a2
to
4831010
Compare
Signed-off-by: Adam Kupczyk akupczyk@redhat.com