Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add --max-buckets to radosgw-admin(8) #17439

Merged
merged 2 commits into from Dec 29, 2017

Conversation

ClemPi
Copy link
Contributor

@ClemPi ClemPi commented Sep 4, 2017

Signed-off-by: Clément Pellegrini clement.pellegrini@qarnot-computing.com

@@ -274,6 +274,10 @@ Options

Temporary url key.

.. option:: --max-buckets

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why this option is not placed at end?
Why this is placed in b/w?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to place it just before --system as in radosgw-admin usage.

But as other options are missing, that's probably not the perfect place, I can either place it a the end, or keep it here and create another PR for other missing options.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ClemPi might want to mention that "max-bucket" is 1000 by default.

@tchaikov
Copy link
Contributor

@ClemPi ping?

@ClemPi ClemPi force-pushed the wip-doc-radosgw-admin-max-buckets branch 3 times, most recently from 08a0dcf to 3d53a07 Compare November 22, 2017 11:52
Signed-off-by: Clément Pellegrini <clement.pellegrini@qarnot-computing.com>
@ClemPi ClemPi force-pushed the wip-doc-radosgw-admin-max-buckets branch from 3d53a07 to d681e00 Compare November 22, 2017 11:53
@ClemPi
Copy link
Contributor Author

ClemPi commented Nov 22, 2017

@tchaikov updated

@liewegas liewegas merged commit 12733fe into ceph:master Dec 29, 2017
@joscollin
Copy link
Member

@liewegas --max-buckets is already updated and merged here: 76a8dc1 on Nov 29, 2017.

Now this merge creates the jenkins doc build error, as this is a duplicate target name in radosgw-admin.rst:

Warning, treated as error:
/home/jenkins-build/build/workspace/ceph-pr-docs/doc/man/8/radosgw-admin.rst:527:Duplicate explicit target name: "cmdoption-radosgw-admin--max-buckets".
Build step 'Execute shell' marked build as failure
[BFA] Scanning build for known causes...
[BFA] No failure causes found
[BFA] Done. 0s
Setting status of dddd3b1d9b3043eb2d43fae65ac9b32d9cc44fe2 to FAILURE with url https://jenkins.ceph.com/job/ceph-pr-docs/8008/ and message: 'Docs: failed with errors
 '
Using context: Docs: build check
Finished: FAILURE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants