rgw: update outdated debug func name #17440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikulely
force-pushed
the
cleanup-iterate
branch
from
dfa852e
to
ab71a98
Compare
amitkumar50
approved these changes
Sep 4, 2017
|
@joscollin @cbodley mind to merge? |
cbodley
reviewed
Oct 16, 2017
src/rgw/rgw_rados.cc
Outdated
| @@ -10645,13 +10645,13 @@ int RGWRados::Object::Read::iterate(int64_t ofs, int64_t end, RGWGetDataCB *cb) | |||
| while (!done) { | |||
| r = data->wait_next_io(&done); | |||
| if (r < 0) { | |||
| dout(10) << "get_obj_iterate() r=" << r << ", canceling all io" << dendl; | |||
| dout(10) << __func__ << " r=" << r << ", cancelling all io" << dendl; | |||
There was a problem hiding this comment.
nit: canceling is also a correct spelling, so i'd prefer not to change it
There was a problem hiding this comment.
@cbodley canceling is American and cancelling is British. So for people on the Eastern side of the world cancelling looks correct :-D
https://english.stackexchange.com/questions/42745/canceling-or-cancelling
I think, let's follow American, as cbodley suggests.
Signed-off-by: Jiaying Ren <jiaying.ren@umcloud.com>
mikulely
force-pushed
the
cleanup-iterate
branch
from
ab71a98
to
18b5482
Compare
|
Jenkins, retest this please. |
cbodley
approved these changes
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.