Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: add bluestore_prefer_deferred_size_hdd/ssd to tracked keys #17459

Merged
merged 1 commit into from Sep 6, 2017

Conversation

xiexingguo
Copy link
Member

To make these two keys can be changed online:

./bin/ceph tell osd.* injectargs "--bluestore_prefer_deferred_size_hdd 0"
osd.0: bluestore_prefer_deferred_size_hdd = '0' (not observed, change may require restart)
osd.1: bluestore_prefer_deferred_size_hdd = '0' (not observed, change may require restart)
osd.2: bluestore_prefer_deferred_size_hdd = '0' (not observed, change may require restart)

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

To make these two keys can be changed online:

./bin/ceph tell osd.* injectargs "--bluestore_prefer_deferred_size_hdd 0"
osd.0: bluestore_prefer_deferred_size_hdd = '0' (not observed, change may require restart)
osd.1: bluestore_prefer_deferred_size_hdd = '0' (not observed, change may require restart)
osd.2: bluestore_prefer_deferred_size_hdd = '0' (not observed, change may require restart)

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@liupan1111
Copy link
Contributor

This change is useful for me, I could tune the performance without restart osd. But why "(not observed, change may require restart)" dumped? Is this option injection workable or not??

@xiexingguo
Copy link
Member Author

But why "(not observed, change may require restart)" dumped? Is this option injection workable or not??

Sorry:-(

That was the output before this change, works now:

./bin/ceph tell osd.* injectargs "--bluestore_prefer_deferred_size_ssd 0"

osd.0: bluestore_prefer_deferred_size_ssd = '0' 
osd.1: bluestore_prefer_deferred_size_ssd = '0' 
osd.2: bluestore_prefer_deferred_size_ssd = '0' 

@liewegas liewegas merged commit 267750e into ceph:master Sep 6, 2017
@liewegas
Copy link
Member

liewegas commented Sep 6, 2017

#17534 backport

@xiexingguo xiexingguo deleted the wip-bs-tracked-key branch September 7, 2017 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants