githubmap: add some known Ceph reviewers #17507
Conversation
.githubmap
Outdated
| liupan1111 Pan Liu <liupan1111@gmail.com> | ||
| majianpeng Jianpeng Ma <jianpeng.ma@intel.com> | ||
| markhpc Mark Nelson <mnelson@redhat.com> | ||
| rchagam Chagam, Anjaneya <anjaneya.chagam@intel.com> |
There was a problem hiding this comment.
This one is different from others: Lastname, Firstname. Need to correct it ?
There was a problem hiding this comment.
@batrick I was thinking, do we have to create PRs like this to update .githubmap or let the Reviewer or Merging Person do it later during their Review/Merge ? What is the plan ?
There was a problem hiding this comment.
Personally, I would recommend the reviewer just adding the username to .githubmap in a quick single commit to master. Then merge onto that.
For scripts that use .githubmap to function, the file must be up-to-date before the merge...
There was a problem hiding this comment.
@batrick I think, as there is no script at the moment, you can send an email to the ceph-devel mailinglist informing this plan to everyone.
Selection from [1] where the GitHub username is available. [1] http://pad.ceph.com/p/reviewers Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
batrick
force-pushed
the
githubmap-update
branch
from
f433261
to
4cb459a
Compare
joscollin
changed the title
Selection from [1] where the GitHub username is available.
[1] http://pad.ceph.com/p/reviewers
Signed-off-by: Patrick Donnelly pdonnell@redhat.com