Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/bluestore: remove useless function submit #17537

Merged
merged 1 commit into from Sep 12, 2017
Merged

os/bluestore: remove useless function submit #17537

merged 1 commit into from Sep 12, 2017

Conversation

mychoxin
Copy link
Contributor

@mychoxin mychoxin commented Sep 7, 2017

Signed-off-by: mychoxin mychoxin@gmail.com

@mychoxin
os/bluestore: remove useless function submit
22c1421 
Signed-off-by: mychoxin <mychoxin@gmail.com>
@mychoxin
Copy link
Contributor Author

mychoxin commented Sep 7, 2017

@joscollin

@joscollin joscollin self-requested a review September 7, 2017 02:22
@liupan1111
Copy link
Contributor

#17524

something related to submit is under discussion, let's hold on this PR until 17524 get conclusion.

@joscollin
Copy link
Member

@liupan1111 ok, I will put this as DNM then.

@mychoxin Please ping me when it is ready for review.

@joscollin joscollin added the DNM label Sep 7, 2017
liewegas
liewegas approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@liewegas liewegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me. we don't have any users now and aren't likely to get any

@liewegas liewegas added needs-qa and removed DNM labels Sep 8, 2017
joscollin
joscollin approved these changes Sep 9, 2017
View reviewed changes
Copy link
Member

@joscollin joscollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joscollin
Copy link
Member

Test Result:

@liewegas liewegas merged commit c54602c into ceph:master Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liewegas liewegas liewegas approved these changes

@joscollin joscollin joscollin approved these changes

Assignees
No one assigned
Labels
bluestore cleanup needs-qa wip-jcollin-testing
Projects
None yet
Milestone
No milestone
4 participants
@mychoxin @liupan1111 @joscollin @liewegas