vstart.sh: Remove duplicate global section #17543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joscollin Please help take a look，Thanks |
tchaikov
reviewed
Sep 8, 2017
| @@ -440,6 +440,7 @@ prepare_conf() { | |||
| filestore fd cache size = 32 | |||
| run dir = $CEPH_OUT_DIR | |||
| enable experimental unrecoverable data corrupting features = * | |||
| $extra_conf | |||
There was a problem hiding this comment.
you might want to make sure $extra_conf is able to override the settings in all sections. for example, the default settings of [client] will override that the $extra_conf with your change.
|
see de4474a .. this was deliberately at the end so that it overrides the stuff that is already in there. I think you're probably right that this particular line can move back, but please test and verify that overriding a config that is in [global] already with -o 'foo = bar' will work correctly. |
|
and yeah, let's add it to [client] too |
Signed-off-by: iliul <liul124@chinaunicom.cn>
|
@liewegas added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove duplicate global section，move
$extra_confto the first global section