client: fix request reference leak #17545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if request gets aborted, its reference leaks. Fixes: http://tracker.ceph.com/issues/21274 Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
batrick
reviewed
Sep 7, 2017
| @@ -1731,6 +1731,7 @@ int Client::make_request(MetaRequest *request, | |||
| r = request->get_abort_code(); | |||
| request->item.remove_myself(); | |||
| unregister_request(request); | |||
| put_request(request); | |||
There was a problem hiding this comment.
Doesn't unregister_request also do put_request?
There was a problem hiding this comment.
both mds_requests map and caller of make_reuqets() hold a reference. unregister_request() releases reference hold by mds_requests map
There was a problem hiding this comment.
sorry, my bad =( introduced by 9cb7906. it's a "potential" use-after-free.
jtlayton
approved these changes
Sep 11, 2017
batrick
approved these changes
Sep 11, 2017
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Sep 13, 2017
* refs/remotes/upstream/pull/17545/head: client: fix request reference leak Reviewed-by: Patrick Donnelly <pdonnell@redhat.com> Reviewed-by: Jeff Layton <jlayton@redhat.com>
batrick
added a commit
that referenced
this pull request
Sep 14, 2017
* refs/remotes/upstream/pull/17545/head: client: fix request reference leak Reviewed-by: Patrick Donnelly <pdonnell@redhat.com> Reviewed-by: Jeff Layton <jlayton@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if request gets aborted, its reference leaks.
Fixes: http://tracker.ceph.com/issues/21274
Signed-off-by: "Yan, Zheng" zyan@redhat.com