Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/workunits/rbd: relax greps to support upgrade formatting change #17559

Merged
merged 1 commit into from Sep 9, 2017

Conversation

dillaman
Copy link

@dillaman dillaman commented Sep 7, 2017

Fixes: http://tracker.ceph.com/issues/21181
Signed-off-by: Jason Dillaman dillaman@redhat.com

Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though a more stable to format changes solution could be to use xml format output, e.g:

[ "$(rbd --format xml info sparse1 | $XMLSTARLET sel -t -v //image/size)" -eq 2097152 ]

@trociny trociny merged commit 0bafa7e into ceph:master Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants