Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msg: Initializing class members in module msg #17568

Merged
merged 1 commit into from Sep 15, 2017
Merged

msg: Initializing class members in module msg #17568

merged 1 commit into from Sep 15, 2017

Conversation

amitkumar50
Copy link

Fixes the coverity issues:

** 1414530 Uninitialized pointer field

  1. uninit_member: Non-static class member tx_cq is not initialized
    in this constructor nor in any functions that it calls.
  2. uninit_member: Non-static class member rx_cq is not initialized
    in this constructor nor in any functions that it calls.
  3. uninit_member: Non-static class member tx_cc is not initialized
    in this constructor nor in any functions that it calls.
    CID 1414530 (FreeBSD support. #1 of 1): Uninitialized pointer field (UNINIT_CTOR)
  4. uninit_member: Non-static class member rx_cc is not initialized
    in this constructor nor in any functions that it calls.

** 1416369 Uninitialized pointer field

CID 1416369 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
4. uninit_member: Non-static class member send is not initialized
in this constructor nor in any functions that it calls.

** 1405536 Uninitialized pointer field

CID 1405536 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member msgr is not initialized
in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com

msg: Initializing class members in module msg
660ab81 
Fixes the coverity issues:

** 1414530 Uninitialized pointer field
2. uninit_member: Non-static class member tx_cq is not initialized
in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member rx_cq is not initialized
in this constructor nor in any functions that it calls.
6. uninit_member: Non-static class member tx_cc is not initialized
in this constructor nor in any functions that it calls.
CID 1414530 (ceph#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
8. uninit_member: Non-static class member rx_cc is not initialized
in this constructor nor in any functions that it calls.

** 1416369 Uninitialized pointer field
CID 1416369 (ceph#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
4. uninit_member: Non-static class member send is not initialized
in this constructor nor in any functions that it calls.

** 1405536 Uninitialized pointer field
CID 1405536 (ceph#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member msgr is not initialized
in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar <amitkuma@redhat.com>
joscollin
joscollin approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@joscollin joscollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tchaikov
Copy link
Contributor

@tchaikov tchaikov merged commit f65c186 into ceph:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joscollin joscollin joscollin approved these changes

Assignees
No one assigned
Labels
cleanup core needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
4 participants
@amitkumar50 @tchaikov @joscollin @liewegas