mon: fix dropping mgr metadata for active mgr (#21260) #17571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
approved these changes
Sep 8, 2017
qa/tasks/mgr/test_failover.py
Outdated
| id_to_meta = dict([(i['id'], i) for i in meta]) | ||
| self.assertIn(original_active, id_to_meta) | ||
| self.assertIn('ceph_version', id_to_meta[original_active]) | ||
| for i in original_standbys: |
There was a problem hiding this comment.
nit, could put:
for i in [original_active] + original_standbys:
self.assertIn(i, id_to_meta)
self.assertIn('ceph_version', id_to_meta[i])
added 2 commits
September 8, 2017 15:45
(aka http://tracker.ceph.com/issues/21260) Fixes: http://tracker.ceph.com/issues/21260 Signed-off-by: John Spray <john.spray@redhat.com>
drop_standby() was killing it and it was only getting added back in certain locations. Instead, make the metadata drop conditional and only do it in the places we're really dropping the daemon, not when we're promoting it to active. Fixes: http://tracker.ceph.com/issues/21260 Signed-off-by: John Spray <john.spray@redhat.com>
tchaikov
approved these changes
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.