os/bluestore: shrink aio submit size to pending value #17588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liupan1111
reviewed
Sep 8, 2017
| @@ -520,7 +520,7 @@ void KernelDevice::aio_submit(IOContext *ioc) | |||
| void *priv = static_cast<void*>(ioc); | |||
| int r, retries = 0; | |||
| r = aio_queue.submit_batch(ioc->running_aios.begin(), e, | |||
| ioc->num_running.load(), priv, &retries); | |||
| pending, priv, &retries); | |||
There was a problem hiding this comment.
If I understand correct, you mean some IOs will be submit more than ones in old code. Right?
There was a problem hiding this comment.
hi, sorry for confused. I am not mean that, i mean there are some memory waste in struct iocb *piocb[aios_size] in submit_batch funtion.
ios were submitted from running_aios.begin() to e, no old ios were submitted. but the total io size should be pending size, but it passed num_running.load() as aios_size to aio_submit(), num_running.load >=pending, num_running.load() may be very large, so it will make memory waste, am i describe clear?
There was a problem hiding this comment.
do you really meet this case during test?
|
Rebase please? |
Signed-off-by: kungf <yang.wang@easystack.cn>
kungf
force-pushed
the
aio_submit_size_change
branch
from
411838f
to
9388de7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running_aios size may be very large in high work load, because we only submit pending aios, so we better apply pending aios size array in aio_queue_t::submit_batch.
@yangdongsheng
@liewegas need a review,please