Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/OSDMonitor: don't create pgs if pool was deleted #17600

Merged
merged 2 commits into from Sep 10, 2017

Conversation

Projects
None yet
3 participants
@jecluis
Copy link
Member

commented Sep 8, 2017

Deleting a pool while its PGs are still being created will lead to an assertion, as described in http://tracker.ceph.com/issues/21309

With this patch, we aim at preventing queuing other pgs to be created if the pool has been deleted.

Fixes: http://tracker.ceph.com/issues/21309
Signed-Off-By: Joao Eduardo Luis <joao@suse.de>

mon/OSDMonitor: fix typo
Signed-off-by: Joao Eduardo Luis <joao@suse.de>

@jecluis jecluis added this to the luminous milestone Sep 8, 2017

@jecluis jecluis requested review from tchaikov and liewegas Sep 8, 2017

@jecluis jecluis changed the title Wip 21309 mon/OSDMonitor: don't create pgs if pool was deleted Sep 8, 2017

@@ -723,6 +723,12 @@ OSDMonitor::update_pending_pgs(const OSDMap::Incremental& inc)
!pending_creatings.queue.empty()) {
auto p = pending_creatings.queue.begin();
int64_t poolid = p->first;
if (inc.old_pools.find(poolid) != inc.old_pools.end()) {

This comment has been minimized.

Copy link
@tchaikov

tchaikov Sep 8, 2017

Contributor

might want to move this trimming logic into creating_pgs_t::remove_pool()

mon/OSDMonitor: don't create pgs if pool was deleted
A pool may be deleted while in the process of creating pgs. If that
happens, we should not queue additional pgs from that pool to be
created.

Fixes: http://tracker.ceph.com/issues/21309

Signed-off-by: Joao Eduardo Luis <joao@suse.de>

@jecluis jecluis force-pushed the jecluis:wip-21309 branch from 958f6fb to 7a8a880 Sep 8, 2017

@liewegas liewegas removed this from the luminous milestone Sep 10, 2017

@liewegas liewegas merged commit fbeea65 into ceph:master Sep 10, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.