mon/OSDMonitor: don't create pgs if pool was deleted #17600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
jecluis
changed the title
tchaikov
reviewed
Sep 8, 2017
src/mon/OSDMonitor.cc
Outdated
| @@ -723,6 +723,12 @@ OSDMonitor::update_pending_pgs(const OSDMap::Incremental& inc) | |||
| !pending_creatings.queue.empty()) { | |||
| auto p = pending_creatings.queue.begin(); | |||
| int64_t poolid = p->first; | |||
| if (inc.old_pools.find(poolid) != inc.old_pools.end()) { | |||
There was a problem hiding this comment.
might want to move this trimming logic into creating_pgs_t::remove_pool()
A pool may be deleted while in the process of creating pgs. If that happens, we should not queue additional pgs from that pool to be created. Fixes: http://tracker.ceph.com/issues/21309 Signed-off-by: Joao Eduardo Luis <joao@suse.de>
tchaikov
approved these changes
Sep 8, 2017
liewegas
approved these changes
Sep 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting a pool while its PGs are still being created will lead to an assertion, as described in http://tracker.ceph.com/issues/21309
With this patch, we aim at preventing queuing other pgs to be created if the pool has been deleted.
Fixes: http://tracker.ceph.com/issues/21309
Signed-Off-By:
Joao Eduardo Luis <joao@suse.de>