os/bluestore: fix deferred write deadlock, aio short return handling #17601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lock serves no purpose. It only protects the call to the aio_submit on the OpSequencer running batch, but we are the only caller who will do that submission, and a new batch won't be moved into place until ours is completed and retired (by the completion for the aio we are queueing). More importantly, this fixes a deadlock: - thread A submits aio, but the queue is full, and blocks - thread B blocks taking deferred_submit_lock while holding deferred_lock - aio completion thread blocks trying to take deferred_lock, and thus no further aios are drained. Fixes: http://tracker.ceph.com/issues/21171 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 7a5ef62)
Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 11ac691)
io_submit may return a value less than nr, indicating that only some of the provided iocbs were queued. If that happens we should loop, not return and silently drop those aios on the floor. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit dc17dfd)
|
jenkins test docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/21325