ceph-volume allow filtering by uuid, do not require osd id
#17606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfredodeza
changed the title
uuid, do not require osd id
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume centos7-create |
|
jenkins test ceph-volume xenial-create |
andrewschoen
approved these changes
Sep 8, 2017
| vg_tags = "ceph.group=dmcache,ceph.disk_type=ssd" | ||
| osd = api.VolumeGroup(vg_name='volume1', vg_path='/dev/vg/lv', vg_tags=vg_tags) | ||
| volume_groups.append(osd) | ||
| # note the different osd_id! |
There was a problem hiding this comment.
I don't think this comment is needed here.
|
jenkins test ceph-volume xenial-create |
|
jenkins test ceph-volume centos7-create |
|
jenkins test ceph-volume xenial-create |
|
jenkins test ceph-volume centos7-create |
added 6 commits
September 11, 2017 09:08
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
alfredodeza
force-pushed
the
wip-bz1478598
branch
from
0877c2e
to
ace3018
Compare
|
jenkins test ceph-volume xenial-create |
|
jenkins test ceph-volume centos7-create |
1 similar comment
|
jenkins test ceph-volume centos7-create |
|
jenkins test ceph-volume xenial-create |
alfredodeza
force-pushed
the
wip-bz1478598
branch
from
c2224fd
to
ecd5af8
Compare
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
…just one Signed-off-by: Alfredo Deza <adeza@redhat.com>
This updates our Vagrantfile to match the changes in ceph-ansible introduced by ceph/ceph-ansible@298a63c43 Signed-off-by: Andrew Schoen <aschoen@redhat.com>
When the osd ID existed in the UUID in the same format (e.g. '1-') the parsing would break returning a bogus UUID that is impossible to find Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an OSD, it should suffice using/requiring the OSD fsid (uuid), these changes will enable that ability.
While implementing that and writing new tests, it was clear that all the
.filter()calls with lvm tags where matching on any one tag, vs. matching all the tags that were passed on.This would cause (internally) filtering volumes by
ceph.type=journal, ceph.osd_id=1would return more than one volume ifjournalwas matched (regardless of the id).Fixes for that issue meant fixing them for Volume Group and Physical Volume APIs too. Tests where added for those.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1478598