rgw: set bucket versioninig donot change versioning status if missing status in xml #17662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cbodley please take a look, thx |
|
jenkins test this please |
|
hi @shashalu, i'm looking at the put bucket versioning api and it lists the Status as optional, so i would prefer not to reject the request if it's missing. if missing, we should just not change the versioning status of the bucket (if it's enabled, leave it enabled - if suspended, leave suspended). what do you think? |
…g "Status" in xml Fixes: http://tracker.ceph.com/issues/21364 Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>
shashalu
force-pushed
the
fix-set-bucket-versioning
branch
from
b0437d5
to
2d5195b
Compare
|
@cbodley Agree. If it's nonversioned, leave it nonversioned. I revised the commit. |
shashalu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/21364
Signed-off-by: Shasha Lu lu.shasha@eisoo.com