osd: Initialization of data members #17691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscollin
requested changes
Sep 15, 2017
src/osd/PrimaryLogPG.cc
Outdated
| @@ -4404,7 +4404,7 @@ struct C_ChecksumRead : public Context { | |||
| OSDOp &osd_op; | |||
| Checksummer::CSumType csum_type; | |||
| bufferlist init_value_bl; | |||
| ceph_le64 read_length; | |||
| ceph_le64 read_length {}; | |||
There was a problem hiding this comment.
Nit: Avoid unwanted space before {
amitkumar50
force-pushed
the
cov-osd-3
branch
from
198a866
to
4420cee
Compare
|
Done Thanks @joscollin |
joscollin
requested changes
Sep 18, 2017
src/osd/PrimaryLogPG.cc
Outdated
| @@ -4404,7 +4404,7 @@ struct C_ChecksumRead : public Context { | |||
| OSDOp &osd_op; | |||
| Checksummer::CSumType csum_type; | |||
| bufferlist init_value_bl; | |||
| ceph_le64 read_length; | |||
| ceph_le64 read_length{}; | |||
There was a problem hiding this comment.
ceph_le64 seems to be an unsigned integer. So better initialize with 0 to be specific.
|
Done Thanks @joscollin |
joscollin
previously approved these changes
Oct 20, 2017
|
amitkumar50
force-pushed
the
cov-osd-3
branch
from
c0ab7e9
to
de90bd6
Compare
|
@tchaikov Done Changes. Thanks |
Fixes the coverity issues: ** 717336 Uninitialized scalar field CID 717336 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member whitelisted is not initialized in this constructor nor in any functions that it calls. ** 728001 Uninitialized scalar field CID 728001 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member priority is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Amit Kumar <amitkuma@redhat.com>
|
@tchaikov can you plz review |
tchaikov
approved these changes
Dec 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the coverity issues:
** 717336 Uninitialized scalar field
** 728001 Uninitialized scalar field
** 1405358 Uninitialized scalar field
Signed-off-by: Amit Kumar amitkuma@redhat.com