librbd: address coverity false positives #17696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscollin
previously requested changes
Sep 13, 2017
There was a problem hiding this comment.
Please do a local build success before creating the PR
/home/jenkins-build/build/workspace/ceph-pull-requests/src/librbd/api/Mirror.cc:85:44: error: ‘PROMOTION_STATE_PRIMARY’ was not declared in this scope
mirror::PromotionState promotion_state = PROMOTION_STATE_PRIMARY;
|
@amitkumar50 this doesn't build |
amitkumar50
force-pushed
the
cov-librbd-3
branch
from
52f1bca
to
2ae36e5
Compare
|
@dillaman Done changes. Thanks. Kindly test now. |
|
Jenkins retest this please |
Fixes the coverity issues: ** 1402627 Uninitialized scalar field CID 1402627 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member promotion_state is not initialized in this constructor nor in any functions that it calls. ** 1402630 Uninitialized scalar field CID 1402630 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member m_promotion_state is not initialized in this constructor nor in any functions that it calls. ** 1402631 Uninitialized scalar field CID 1402631 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member m_promotion_state is not initialized in this constructor nor in any functions that it calls. ** 1402632 Uninitialized scalar field CID 1402632 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member tag_tid is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Amit Kumar <amitkuma@redhat.com>
dillaman
approved these changes
Sep 14, 2017
dillaman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the coverity issues:
** 1402627 Uninitialized scalar field
** 1402630 Uninitialized scalar field
** 1402631 Uninitialized scalar field
** 1402632 Uninitialized scalar field
Signed-off-by: Amit Kumar amitkuma@redhat.com