os/bluestore: allocate entire write in one go #17698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the first pass through the writes, compress data and calculate a final amount of space we need to allocate. On the second pass, assign the extents to blobs and queue the writes. This allows us to do a single allocation for all blobs, which will lead to less fragmentation and a much better write pattern. Signed-off-by: Sage Weil <sage@redhat.com>
xiexingguo
reviewed
Sep 16, 2017
| txc->statfs_delta.allocated() += got; | ||
| int64_t left = final_length; | ||
| while (left > 0) { | ||
| assert(prealloc_left > 0); |
There was a problem hiding this comment.
assert(prealloc_pos != prealloc.end()); ? Otherwise we are at risk of access violation.
xiexingguo
approved these changes
Sep 16, 2017
|
lgtm and good patch! |
|
I think this deserves to be backported to luminous: #18033 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the first pass through the writes, compress data and calculate a final
amount of space we need to allocate. On the second pass, assign the
extents to blobs and queue the writes.
This allows us to do a single allocation for all blobs, which will lead
to less fragmentation and a much better write pattern.
Signed-off-by: Sage Weil sage@redhat.com