Performance: Only scan for omap corruption once #17705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix hard-coded "leveldb" backend. The command is broken in Luminous now that "rocksdb" is the default. Signed-off-by: David Zafman <dzafman@redhat.com>
Signed-off-by: David Zafman <dzafman@redhat.com>
Available for testing and user downgrade. Signed-off-by: David Zafman <dzafman@redhat.com>
Before state 2: Can have complete tables (some may be bad) state 3: Never had complete tables After state 2: Can have complete tables (some may be bad) state 3 with legacy: Can have complete tables (bad ones are cleared) state 3: Never had complete tables Once OSDs boot with this change you can't downgrade to a previous release. If someone does downgrade they could have unstable OSDs that hit assert(state.v < 3). The following command run after shutting down the cluster but before downgrading ceph packages would be a way to fix this. ceph-osdomap-tool --omap-path ... --command resetv2 Fixes: http://tracker.ceph.com/issues/21328 Signed-off-by: David Zafman <dzafman@redhat.com>
|
It seems this was merged after the luminous split. Opened luminous backport PR: #18301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/21328