Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/options: document filestore and filejournal options #17739

Merged
merged 1 commit into from Sep 22, 2017

Conversation

liewegas
Copy link
Member

Signed-off-by: Sage Weil sage@redhat.com

Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from the nit, lgtm.


Option("filestore_wbthrottle_xfs_bytes_start_flusher", Option::TYPE_UINT, Option::LEVEL_ADVANCED)
.set_default(41943040)
.set_description(""),
.set_description("Start flushing (fsyncing) when this many bytes are written(xfs)"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a space after "written"

@tchaikov
Copy link
Contributor

and need rebase.

Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas liewegas merged commit 3a6a0f4 into ceph:master Sep 22, 2017
@liewegas liewegas deleted the wip-filestore-configs branch September 22, 2017 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants