Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph-mgr: can not change prometheus port for mgr #17746

Merged
merged 1 commit into from Oct 4, 2017
Merged

ceph-mgr: can not change prometheus port for mgr #17746

merged 1 commit into from Oct 4, 2017

Conversation

elliswuuuuuuuu
Copy link
Contributor

No description provided.

@tchaikov
Copy link
Contributor

@elliswuuuuuuuu could you add a "Signed-off-by" line at the end of your commit message? "git commit -s" will do the trick for you. see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#1-sign-your-work

@tchaikov tchaikov requested a review from dmick September 15, 2017 05:07
@elliswuuuuuuuu
ceph-mgr: can not change prometheus port for mgr
6cc0338 
Signed-off-by: wujian <wujian3659@163.com>
@elliswuuuuuuuu
Copy link
Contributor Author

@ceph-jenkins please retest it

@jcsp
Copy link
Contributor

jcsp commented Sep 15, 2017

retest this please

^^ that's the magic jenkins command per https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin

@joscollin
Copy link
Member

retest this please

@jcsp jcsp merged commit e25d30c into ceph:master Oct 4, 2017
@jcsp jcsp mentioned this pull request Oct 4, 2017
Merged
@elliswuuuuuuuu elliswuuuuuuuu deleted the wip-prometheus branch May 31, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

@dmick dmick Awaiting requested review from dmick

Assignees
No one assigned
Labels
bug-fix mgr
Projects
None yet
Milestone
No milestone
4 participants
@elliswuuuuuuuu @tchaikov @jcsp @joscollin