New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa/tests: Add additional required ceph-ansible vars due to upstream changes #17757
Conversation
ceph_stable_release: luminous | ||
osd_scenario: collocated | ||
ceph_origin: repository | ||
ceph_repository: community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ceph_repository
should be set to dev
if you're installing packages from shaman and ceph_dev
is no longer valid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewschoen are you sure? This one I copied from other ceph-ansible suite which is working, I will check the logs there. ceph_dev is internal set in task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vasukulkarni I'm pretty sure that if ceph_repository: community
is set you'll be getting packages from download.ceph.com. I'm not surprised the job is passing, but I bet you aren't installing what you think you are. Yeah, ceph_dev
isn't an option at all anymore either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @andrewschoen , It is from download.ceph.com as you pointed out http://qa-proxy.ceph.com/teuthology/vasu-2017-09-12_20:21:30-ceph-ansible-master-distro-basic-ovh/1624063/teuthology.log and I will remove the ceph_dev key.
ceph_stable_release: luminous | ||
osd_scenario: collocated | ||
ceph_origin: repository | ||
ceph_repository: community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, this should be dev
and ceph_dev
removed
@yuriw test with ceph/teuthology#1110 |
0fc5c84
to
a58df44
Compare
@andrewschoen mind looking at it again and approving it ? I have updated the other suite as well, In the task ceph_dev_branch is set to sha, hopefully that is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments here shouldn't hurt anything, it's more cleanup than anything else.
@@ -8,7 +8,6 @@ overrides: | |||
global: | |||
osd default pool size: 2 | |||
mon pg warn min per osd: 2 | |||
ceph_dev: true | |||
ceph_dev_key: https://download.ceph.com/keys/autobuild.asc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ceph_dev_key
isn't needed either
debug ms: 1 | ||
ceph_test: true | ||
ceph_dev: true | ||
ceph_dev_key: https://download.ceph.com/keys/autobuild.asc | ||
ceph_origin: upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should remove any instance of ceph_origin: upstream
as it's not a valid option for ceph_origin
and you've already got it defined as repository
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewschoen thanks will remove both of them (dev_key and _origin).
@vasukulkarni @smithfarm @theanalyst needs backporting luminous and maybe jewel? |
there is a merge conflict which needs resolving |
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
79a0e40
to
e11a1f7
Compare
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
17e8536
to
56d1511
Compare
a) tracker: http://tracker.ceph.com/issues/21497 for rgw issue |
@yuriw want to test with this? Just those 2 tests?
Signed-off-by: Vasu Kulkarni vasu@redhat.com