Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tests: Add additional required ceph-ansible vars due to upstream changes #17757

Merged
merged 4 commits into from Sep 22, 2017

Conversation

Projects
None yet
4 participants
@vasukulkarni
Copy link
Member

commented Sep 15, 2017

@yuriw want to test with this? Just those 2 tests?

Signed-off-by: Vasu Kulkarni vasu@redhat.com

@vasukulkarni vasukulkarni added the tests label Sep 15, 2017

@vasukulkarni vasukulkarni requested a review from yuriw Sep 15, 2017

ceph_stable_release: luminous
osd_scenario: collocated
ceph_origin: repository
ceph_repository: community

This comment has been minimized.

Copy link
@andrewschoen

andrewschoen Sep 15, 2017

Contributor

ceph_repository should be set to dev if you're installing packages from shaman and ceph_dev is no longer valid

This comment has been minimized.

Copy link
@vasukulkarni

vasukulkarni Sep 15, 2017

Author Member

@andrewschoen are you sure? This one I copied from other ceph-ansible suite which is working, I will check the logs there. ceph_dev is internal set in task.

This comment has been minimized.

Copy link
@andrewschoen

andrewschoen Sep 15, 2017

Contributor

@vasukulkarni I'm pretty sure that if ceph_repository: community is set you'll be getting packages from download.ceph.com. I'm not surprised the job is passing, but I bet you aren't installing what you think you are. Yeah, ceph_dev isn't an option at all anymore either.

This comment has been minimized.

Copy link
@vasukulkarni

vasukulkarni Sep 15, 2017

Author Member

thanks @andrewschoen , It is from download.ceph.com as you pointed out http://qa-proxy.ceph.com/teuthology/vasu-2017-09-12_20:21:30-ceph-ansible-master-distro-basic-ovh/1624063/teuthology.log and I will remove the ceph_dev key.

ceph_stable_release: luminous
osd_scenario: collocated
ceph_origin: repository
ceph_repository: community

This comment has been minimized.

Copy link
@andrewschoen

andrewschoen Sep 15, 2017

Contributor

same here, this should be dev and ceph_dev removed

@vasukulkarni

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2017

@vasukulkarni vasukulkarni force-pushed the wip-rgw-ansible-var branch from 0fc5c84 to a58df44 Sep 15, 2017

@vasukulkarni

This comment has been minimized.

Copy link
Member Author

commented Sep 15, 2017

@andrewschoen mind looking at it again and approving it ? I have updated the other suite as well, In the task ceph_dev_branch is set to sha, hopefully that is correct.

@andrewschoen
Copy link
Contributor

left a comment

My comments here shouldn't hurt anything, it's more cleanup than anything else.

@@ -8,7 +8,6 @@ overrides:
global:
osd default pool size: 2
mon pg warn min per osd: 2
ceph_dev: true
ceph_dev_key: https://download.ceph.com/keys/autobuild.asc

This comment has been minimized.

Copy link
@andrewschoen

andrewschoen Sep 15, 2017

Contributor

ceph_dev_key isn't needed either

debug ms: 1
ceph_test: true
ceph_dev: true
ceph_dev_key: https://download.ceph.com/keys/autobuild.asc
ceph_origin: upstream

This comment has been minimized.

Copy link
@andrewschoen

andrewschoen Sep 15, 2017

Contributor

You should remove any instance of ceph_origin: upstream as it's not a valid option for ceph_origin and you've already got it defined as repository.

This comment has been minimized.

Copy link
@vasukulkarni

vasukulkarni Sep 16, 2017

Author Member

@andrewschoen thanks will remove both of them (dev_key and _origin).

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Sep 18, 2017

@vasukulkarni @smithfarm @theanalyst needs backporting luminous and maybe jewel?

@theanalyst

This comment has been minimized.

Copy link
Member

commented Sep 19, 2017

there is a merge conflict which needs resolving

vasukulkarni added some commits Sep 20, 2017

qa/tests: Fix ceph-ansible upstream vars
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
qa/tests: update required ceph-ansbile vars
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
qa/tests: skip test that use public bucket landsat-pds from AWS
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>

@vasukulkarni vasukulkarni force-pushed the wip-rgw-ansible-var branch from 79a0e40 to e11a1f7 Sep 20, 2017

use ovh instead of vps
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>

@vasukulkarni vasukulkarni force-pushed the wip-rgw-ansible-var branch from 17e8536 to 56d1511 Sep 21, 2017

@vasukulkarni

This comment has been minimized.

Copy link
Member Author

commented Sep 22, 2017

@vasukulkarni vasukulkarni merged commit d02de6b into master Sep 22, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@vasukulkarni vasukulkarni deleted the wip-rgw-ansible-var branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.