Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include,messages,rbd: Initialize counter,group_pool #17774

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
3 participants
@amitkumar50
Copy link
Contributor

commented Sep 18, 2017

Fixes the coverity issues:

** 1396182 Uninitialized scalar field

CID 1396182 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member counter is not initialized
in this constructor nor in any functions that it calls.

** 1396194 Uninitialized scalar field

CID 1396194 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member group_pool is not initialized
in this constructor nor in any functions that it calls

Signed-off-by: Amit Kumar amitkuma@redhat.com

@joscollin joscollin added cleanup common core rbd and removed rbd labels Sep 19, 2017

@@ -593,7 +593,7 @@ namespace buffer CEPH_BUFFER_API {

class page_aligned_appender {
bufferlist *pbl;
size_t offset;
size_t offset = 0;

This comment has been minimized.

Copy link
@joscollin

joscollin Sep 19, 2017

Member

Drop it, as it is not used anywhere.

@amitkumar50 amitkumar50 force-pushed the amitkumar50:cov-misc-4 branch from fff1813 to 0372b7b Sep 19, 2017

@amitkumar50 amitkumar50 force-pushed the amitkumar50:cov-misc-4 branch from 0372b7b to b9ff451 Sep 26, 2017

@amitkumar50 amitkumar50 changed the title include,messages,rbd: Initialize offset,counter,group_pool include,messages,rbd: Initialize counter,group_pool Sep 26, 2017

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2017

@joscollin Done changes Thanks

include,messages,rbd: Initialize counter,group_pool
Fixes the coverity issues:

** 1396182 Uninitialized scalar field
CID 1396182 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member counter is not initialized
in this constructor nor in any functions that it calls.

** 1396194 Uninitialized scalar field
CID 1396194 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member group_pool is not initialized
in this constructor nor in any functions that it calls

Signed-off-by: Amit Kumar <amitkuma@redhat.com>
@joscollin

This comment has been minimized.

Copy link
Member

commented Sep 27, 2017

retest this please

@yuriw yuriw merged commit a2d7279 into ceph:master Sep 28, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.