include,messages,rbd: Initialize counter,group_pool #17774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscollin
requested changes
Sep 19, 2017
src/include/buffer.h
Outdated
| @@ -593,7 +593,7 @@ namespace buffer CEPH_BUFFER_API { | |||
|
|
|||
| class page_aligned_appender { | |||
| bufferlist *pbl; | |||
| size_t offset; | |||
| size_t offset = 0; | |||
There was a problem hiding this comment.
Drop it, as it is not used anywhere.
amitkumar50
force-pushed
the
cov-misc-4
branch
from
fff1813
to
0372b7b
Compare
amitkumar50
force-pushed
the
cov-misc-4
branch
from
0372b7b
to
b9ff451
Compare
amitkumar50
changed the title
|
@joscollin Done changes Thanks |
Fixes the coverity issues: ** 1396182 Uninitialized scalar field CID 1396182 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member counter is not initialized in this constructor nor in any functions that it calls. ** 1396194 Uninitialized scalar field CID 1396194 (ceph#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member group_pool is not initialized in this constructor nor in any functions that it calls Signed-off-by: Amit Kumar <amitkuma@redhat.com>
|
retest this please |
joscollin
approved these changes
Sep 27, 2017
|
RADOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the coverity issues:
** 1396182 Uninitialized scalar field
** 1396194 Uninitialized scalar field
Signed-off-by: Amit Kumar amitkuma@redhat.com