rgw: Returning when dst_ioctx.operate() returns error #17873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins retest this please |
cbodley
reviewed
Nov 8, 2017
There was a problem hiding this comment.
thanks @amitkumar50! while you're at it, could you please also add a comment under that done_err: label with something like this?
// TODO: clean up dst_oid if we created it
amitkumar50
force-pushed
the
cov-rgw-8
branch
from
2ec6bfd
to
0f700e7
Compare
|
Thanks @cbodley Done changes. Kindly have a look. |
** 1396179 Unused value CID 1396179 (ceph#1 of 1): Unused value (UNUSED_VALUE) returned_value: Assigning value from dst_ioctx->operate(dst_oid, &wop) to ret here, but that stored value is overwritten before it can be used. Signed-off-by: Amit Kumar <amitkuma@redhat.com>
cbodley
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** 1396179 Unused value
Signed-off-by: Amit Kumar amitkuma@redhat.com