osd: make scrub right now when pg stats_invalid is true #17884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kungf <yang.wang@easystack.cn>
amitkumar50
reviewed
Sep 22, 2017
| if (scrubber.must_scrub || | ||
| (info.stats.stats_invalid && cct->_conf->osd_scrub_invalid_stats)) { | ||
| reg_stamp = ceph_clock_now(); | ||
| must = true; |
There was a problem hiding this comment.
if (info.stats.stats_invalid && cct->_conf->osd_scrub_invalid_stats) == 1 and scrubber.must_scrub == false still must would become true. Though scrubber.must_scrub is false.
So Looks not correct...
There was a problem hiding this comment.
@amitkumar50 thanks for your review. if (info.stats.stats_invalid && cct->_conf->osd_scrub_invalid_stats) == true, then must become ture, then scrub deadline was set to now in PG::reg_next_scrub(), and the pg will do scrub even though scrubber.must_scrub=false, doesn't this logic anything wrong ?
|
@liewegas need a review please. |
liewegas
approved these changes
Sep 22, 2017
dzafman
approved these changes
Sep 25, 2017
|
@kungf why do you think we should scrub immediately if "stats_invalid"? |
tchaikov
reviewed
Sep 28, 2017
|
RADOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reg_stamp was set to ceph_clock_now() when scrubber.must_scrub is true or (info.stats.stats_invalid && cct->_conf->osd_scrub_invalid_stats) is true, but 'must' argument of osd::reg_pg_scrub() was set according to scrubber.must_scrub, so when scrubber.must_scrub is false and (info.stats.stats_invalid && cct->_conf->osd_scrub_invalid_stats) is true, even the scrub was delayed because ceph_clock_now() larger than info.history.last_scrub_stamp.
@yangdongsheng