rgw: dont reuse stale RGWObjectCtx for get_bucket_info() #17916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the earlier call to store->get_bucket_entrypoint_info() failed with ENOENT, the obj_ctx will cache exists=false. put_bucket_entrypoint_info() doesn't invalidate that, so this call to get_bucket_info() was reading from a stale cache and failing with ENOENT Fixes: http://tracker.ceph.com/issues/21506 Signed-off-by: Casey Bodley <cbodley@redhat.com>
oritwas
approved these changes
Sep 24, 2017
rzarzynski
approved these changes
Sep 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the earlier call to store->get_bucket_entrypoint_info() failed with
ENOENT, the obj_ctx will cache exists=false.
put_bucket_entrypoint_info() doesn't invalidate that, so this call to
get_bucket_info() was reading from a stale cache and failing with ENOENT
these failures were causing multisite's metadata sync to stall
Fixes: http://tracker.ceph.com/issues/21506