luminous: ceph_volume_client: perform snapshot operations in #17921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... client configured snap directory name, instead of in hard-coded '.snap' directory. Fixes: http://tracker.ceph.com/issues/21476 Signed-off-by: Ramana Raja <rraja@redhat.com> (cherry picked from commit f4fc172)
|
Delaying until after 12.2.1. |
amitkumar50
approved these changes
Sep 27, 2017
|
This passed a teuthology run at http://tracker.ceph.com/issues/21830#FS and will be merged when approved |
|
@batrick, I'm unable to approve this change. It's a simple fix, and has been in review for a while. Can you please move this along? |
|
Ramana, you can also just a comment and my script will pick up your review (but I realize that won't help with the "Review Required" github barrier)
|
batrick
added a commit
that referenced
this pull request
Oct 29, 2017
* refs/pull/17921/head: ceph_volume_client: perform snapshot operations in Reviewed-by: Amit Kumar <amitkuma@redhat.com> Reviewed-by: Ramana Raja <rraja@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/21514