RGW: fix a bug about inconsistent unit of comparison #17958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscollin
requested changes
Sep 28, 2017
There was a problem hiding this comment.
Add Fixes: in commit message.
See: https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#tag-the-commit
dang
approved these changes
Sep 28, 2017
|
Actually the unit is still "bytes" (rounded) -- but rounding twice is silly, so this change is good. |
mdw-at-linuxbox
approved these changes
Sep 28, 2017
|
For the "Fixes: " fix, you'll need to update the commit itself, not just the conversation here.. There's no logic in github to push chagnes in the "conversation" stream here back into commits. Usually that means doing a "force-push" to get it back to github, because you'll be overwritting the old branch. Once you do that I can merge this. |
Fixes：http://tracker.ceph.com/issues/21590 Signed-off-by: gaosibei <gaosb@inspur.com>
|
Thanks for taking a look! I've updated the commit with “Fixes：http://tracker.ceph.com/issues/21590“ |
joscollin
approved these changes
Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit of cached_stats_num_kb_rounded is KB, and the unit of quota.max_size_soft_threshold is B. We use cached_stats.size_rounded instead of
cached_stats_num_kb_rounded.
Fixes：http://tracker.ceph.com/issues/21590
Signed-off-by: Sibei Gao gaosb@inspur.com