os/bluestore/BlueFS: several cleanups #17966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
force-pushed
the
wip-bluefs-kill-block-total
branch
2 times, most recently
from
2b5c5c4
to
503e5ff
Compare
xiexingguo
force-pushed
the
wip-bluefs-kill-block-total
branch
from
503e5ff
to
863ec71
Compare
liewegas
reviewed
Sep 26, 2017
src/os/bluestore/BlueFS.cc
Outdated
| @@ -1244,7 +1244,7 @@ void BlueFS::_compact_log_async(std::unique_lock<std::mutex>& l) | |||
| << std::dec << dendl; | |||
|
|
|||
| // allocate | |||
| int r = _allocate(BlueFS::BDEV_DB, new_log_jump_to, | |||
| int r = _allocate(log_file->fnode.prefer_bdev, new_log_jump_to, | |||
There was a problem hiding this comment.
My thinking here is that the async compaction isn't blocking, so it isn't latency sensitive.. and the wal device will generally only be big enough for the rocksdb .log files. Since this is only ever read on startup, I don't think there's much value in putting it on the wal device.
xiexingguo
force-pushed
the
wip-bluefs-kill-block-total
branch
from
9e5b05b
to
ef0c60f
Compare
xiexingguo
changed the title
|
@liewegas Dropped that change! |
As block_all will suffice for the same purpose. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
As Allocator will handle it automatically and efficiently! Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
As we might be allocating space from different devices (though the chance is rare). Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
retest this please |
liewegas
approved these changes
Sep 26, 2017
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.