options.cc: document rgw config options #18007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Option("rgw_bucket_quota_soft_threshold", Option::TYPE_FLOAT, Option::LEVEL_ADVANCED) |
There was a problem hiding this comment.
the comment should specify the units
There was a problem hiding this comment.
or, rather, that it is a ratio
theanalyst
reviewed
Oct 4, 2017
|
|
||
| Option("rgw_port", Option::TYPE_STR, Option::LEVEL_ADVANCED) | ||
| .set_default("") | ||
| .set_description(""), | ||
| .set_description("RGW FastCGI port number (for FastCGI over TCP)") | ||
| .add_see_also({"rgw_host", "rgw_fcgi_socket_backlog"}), | ||
|
|
||
| Option("rgw_dns_name", Option::TYPE_STR, Option::LEVEL_ADVANCED) |
There was a problem hiding this comment.
should we drop the level advanced -> level basic in this case?
There was a problem hiding this comment.
yeah, although I'm not sure how much we want to make all the fastcgi stuff visible.
src/common/options.cc
Outdated
| .set_description(""), | ||
| .set_description("Swift-auth storage URL") | ||
| .set_long_description( | ||
| "Used in conjuction with rgw internal swift authentication. This affects the " |
src/common/options.cc
Outdated
| .set_description("Send content length when listing containers (Swift)") | ||
| .set_long_description( | ||
| "Whether content length header is needed when listing containers. When this is " | ||
| "set to false, RGW will send extra info for each entry in the response."), | ||
|
|
||
| Option("rgw_keystone_url", Option::TYPE_STR, Option::LEVEL_ADVANCED) |
There was a problem hiding this comment.
this also may be downgraded to level basic?
yehudasa
force-pushed
the
wip-rgw-config-desc
branch
2 times, most recently
from
27ec983
to
79e58a3
Compare
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
|
Are there still any changes outstanding on this or is it good to go? |
cbodley
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yehuda Sadeh yehuda@redhat.com