common/options: pass by reference and use user-literals for size #18034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for better performance. and for better consistency, pass by std::initializer_list. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-options
branch
from
8e365cf
to
0f8ed94
Compare
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-options
branch
from
0f8ed94
to
6788ea0
Compare
|
retest this please. |
adamemerson
approved these changes
Sep 29, 2017
| @@ -91,7 +91,7 @@ struct Option { | |||
| std::vector<const char*> see_also; | |||
|
|
|||
| value_t min, max; | |||
| std::vector<std::string> enum_allowed; | |||
| std::vector<const char*> enum_allowed; | |||
There was a problem hiding this comment.
Are we sure we want char* rather than std::string here? Not that I'm DEAD SET AGAINST IT, but if we're doing std::string operations with them elsewhere this might be a false economy.
There was a problem hiding this comment.
i am sure, for smaller memory foot print. a temporary std::string() will be created from const char* in Option::dump(), and in Option::validate(), STL offers operator==(const char*, const std::string).
| @@ -599,7 +599,7 @@ std::vector<Option> get_global_options() { | |||
| .set_description(""), | |||
|
|
|||
| Option("ms_tcp_prefetch_max_size", Option::TYPE_INT, Option::LEVEL_ADVANCED) | |||
| .set_default(4096) | |||
| .set_default(4_K) | |||
There was a problem hiding this comment.
This is excellent. Where are these literals defined?
There was a problem hiding this comment.
right in this file. line:144.
|
the failed one is caused by d7b29ac#r141996981, i believe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.