Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailmap: update affiliation for Mykola Golub #18069

Merged
merged 1 commit into from Oct 2, 2017

Conversation

trociny
Copy link
Contributor

@trociny trociny commented Oct 1, 2017

Signed-off-by: Mykola Golub to.my.trociny@gmail.com

@@ -276,6 +276,7 @@ MingXin Liu <mingxin.liu@kylin-cloud.com> <mingxinliu@ubuntukylin.com>
Mingqiao Wu <wumingqiao@inspur.com>
Mingyue Zhao <zhao.mingyue@h3c.com>
Mykola Golub <mgolub@mirantis.com> <mgolub@zhuzha.mirantis.lviv.net>
Mykola Golub <to.my.trociny@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: If to.my.trociny@gmail.com is your primary email id, why can't you map your other email ids (mgolub@mirantis.com and mgolub@zhuzha.mirantis.lviv.net) to the primary email id. For example, see Sage Weil's or Kefu Chai's entry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea was that all commits I had done working at Mirantis would remain associated with mgolub@mirantis.com, and only new commits would be associated with to.my.trociny@gmail.com, which is unaffiliated. I am not sure it is possible though.

Copy link
Member

@theanalyst theanalyst Oct 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trociny just add a .peoplemap entry as well, that will ensure that old commits are still associated, this can remain as it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theanalyst Thanks, updated.

Signed-off-by: Mykola Golub <to.my.trociny@gmail.com>
Copy link
Member

@joscollin joscollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@theanalyst Thanks for the input.

@theanalyst
Copy link
Member

jenkins test this please

@joscollin joscollin changed the title mailmap, organizationmap: update affiliation for Mykola Golub mailmap: update affiliation for Mykola Golub Oct 2, 2017
@joscollin joscollin merged commit de39d5e into ceph:master Oct 2, 2017
@trociny trociny deleted the wip-affiliation branch December 24, 2017 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants