New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mailmap: update affiliation for Mykola Golub #18069
Conversation
@@ -276,6 +276,7 @@ MingXin Liu <mingxin.liu@kylin-cloud.com> <mingxinliu@ubuntukylin.com> | |||
Mingqiao Wu <wumingqiao@inspur.com> | |||
Mingyue Zhao <zhao.mingyue@h3c.com> | |||
Mykola Golub <mgolub@mirantis.com> <mgolub@zhuzha.mirantis.lviv.net> | |||
Mykola Golub <to.my.trociny@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: If to.my.trociny@gmail.com
is your primary email id, why can't you map your other email ids (mgolub@mirantis.com and mgolub@zhuzha.mirantis.lviv.net) to the primary email id. For example, see Sage Weil's or Kefu Chai's entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea was that all commits I had done working at Mirantis would remain associated with mgolub@mirantis.com, and only new commits would be associated with to.my.trociny@gmail.com, which is unaffiliated. I am not sure it is possible though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trociny just add a .peoplemap entry as well, that will ensure that old commits are still associated, this can remain as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theanalyst Thanks, updated.
Signed-off-by: Mykola Golub <to.my.trociny@gmail.com>
e057c4a
to
7dd3cfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@theanalyst Thanks for the input.
jenkins test this please |
Signed-off-by: Mykola Golub to.my.trociny@gmail.com