mon: check monitor address configuration #18073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the monitor port is not specified in ceph.conf, it will use 0. However, monmaptool will use default port in creating monitor map in such case. The inconsistent behavior is not graceful, and every time monitor loading, it warns 'mon addr config option does not match monmap file', which is confusing. Signed-off-by: Li Wang <laurence.liwang@gmail.com>
dragonylffly
changed the title
liewegas
approved these changes
Oct 2, 2017
|
This is a bit of a behavior change.. prevoiusly we would parse "1.2.3.4:123aaa" successfully but now not. Oh, and it looks like the unit test fails as a result. Is there a reason we should change this? |
It checks the validty of monitor port configuration in ceph.conf, and warns if necessary. Signed-off-by: Li Wang <laurence.liwang@gmail.com>
dragonylffly
force-pushed
the
wip-check-monitor-address-configuration
branch
from
c3a4e62
to
6e66bcb
Compare
|
@liewegas updated |
liewegas
approved these changes
Oct 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 check the validity of monitor port configuration
2 use default monitor port when not specified in ceph.conf