tool: ceph-kvstore-tool doesn't umount BlueStore properly #18083
Conversation
src/tools/ceph_kvstore_tool.cc
Outdated
|
|
||
| ~StoreTool() { | ||
| if (bluestore) { | ||
| assert(0 == bluestore->umount()); |
There was a problem hiding this comment.
please move the call with side effects out of the assert, in case we compile out assert() in the future.
There was a problem hiding this comment.
thank you Sage. done, remove assert here.
Fixes: http://tracker.ceph.com/issues/21625 Signed-off-by: Chang Liu <liuchang0812@gmail.com>
liuchang0812
force-pushed
the
wip-21625
branch
from
3d6ce93
to
81e4560
Compare
|
@liuchang0812 do you mind writing a test case that reproduces the original issue? can probably put it in qa/standalone.. maybe a separate dir for tool tests that don't need an actual cluster? |
|
I will do it. we need a bluestore dir, so standalone seems is better? |
|
ceph-objectstore-tool --op mkfs might be helpful.
|
|
Looks good.. is that commit part of another PR? We also need to add a .yaml file in qa/suites/rados/standalone-nomgrs/... somewhere so that it gets run as part of the test suite. |
yeah, PR: #16745 We also need to add a .yaml file in qa/suites/rados/standalone-nomgrs/... somewhere so that it gets run as part of the test suite. I put it in |
Fixes: http://tracker.ceph.com/issues/21625
Signed-off-by: Chang Liu liuchang0812@gmail.com